You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem I am facing is that I always forget to run one of these commands, causing me to have to force update the branch to avoid a single commit just for "lint", "snapshot" or "gas-report".
I would recommend that we run pnpm prepare that is pnpm prettier:write && forge fmt && forge snapshot && pnpm gas-report and ask in checklist to run that instead of these separated commands.
The text was updated successfully, but these errors were encountered:
Yea, I think generally this wouldn't hurt.
Just keep in mind that, even if we hide these sub commands behind a single umbrella command, this won't change the fact that you might have to amend your commit(s) and force update your branch afterwards.
Also, I think the prepare command should also do pnpm prettier:write to account for non solidity files.
Yes, we can set one up I believe.
I found pre-commit hooks a bit annoying in practice, but happy to give this a try if this improves everyone's workflows!
Maybe for the pre-commit just run the forge fmt and prettier write, and for the files that were changed. The verify, test, report might be a little bit too overhead for big projects.
The PR request that we do several steps...
I recommend that some of these steps are done together in a single command:
The problem I am facing is that I always forget to run one of these commands, causing me to have to force update the branch to avoid a single commit just for "lint", "snapshot" or "gas-report".
I would recommend that we run
pnpm prepare
that ispnpm prettier:write && forge fmt && forge snapshot && pnpm gas-report
and ask in checklist to run that instead of these separated commands.The text was updated successfully, but these errors were encountered: