-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1: entity types and structure standardization #1650
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current version has 2 main types of supported entities: country and financial. Not all entities of the country type can be countries per se. As ISO3166 defines a broader set of supported entities, e.g.
names of countries, dependent territories, and special areas of geographical interest
it'd be fair to rename accordingly, useiso3166
as a placeholder for iso3166 based entities. Keeping it as is for financial/market category can be a good idea.The iso3166 entity files would be named according to their iso3166-1 codes.
Another point is the difference for specifying the code for country/market entities: using a standardized attribute name for both types would be more consistent. The difference could be provided based on class inheritance (separate base classes for iso3166 and financial entities) and/or
entity_type
field.Questions and ideas are welcome!
The text was updated successfully, but these errors were encountered: