Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning value when requiring/importing the lib #31

Open
Nargonath opened this issue Aug 3, 2017 · 1 comment
Open

Allow returning value when requiring/importing the lib #31

Nargonath opened this issue Aug 3, 2017 · 1 comment

Comments

@Nargonath
Copy link
Contributor

Would be nice if we could use the lib as is:

import angAccordion from 'ang-accordion';

angular.module('myApp', [angAccordion]);

instead of the current:

import 'ang-accordion';

angular.module('myApp', ['angAccordion']);

If you are ok with this, I'll be happy to make a PR. 👍

Thanks for your library.

@uxxman
Copy link
Owner

uxxman commented Aug 10, 2017

Yes, sure. Thank you for the suggestion :)

Nargonath added a commit to Nargonath/angular-accordion that referenced this issue Aug 16, 2017
Returned the module name from the global function in order to simplify module importation.
Nargonath added a commit to Nargonath/angular-accordion that referenced this issue Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants