Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save" in "Unsaved changes" doesn't do anything #1491

Open
freelon opened this issue Jan 31, 2024 · 9 comments · May be fixed by #3214
Open

"Save" in "Unsaved changes" doesn't do anything #1491

freelon opened this issue Jan 31, 2024 · 9 comments · May be fixed by #3214

Comments

@freelon
Copy link

freelon commented Jan 31, 2024

Bruno version: 1.7.1

Steps to reproduce:

  • modify a request
  • attempt to close Bruno
  • click "Save" in the popup (it lists the file name of the modified request)

... and nothing happens (bruno doesn't close either, which is a good thing). Only the "Don't save" and "Cancel" buttons do what they are supposed to do.

@freelon
Copy link
Author

freelon commented Feb 7, 2024

This seems to be fixed in 1.8.0.

Although I don't know what your PR then maybe changed @giemic8?

@giemic8
Copy link

giemic8 commented Feb 12, 2024

@freelon Are you sure? I can reproduce this Bug on 1.8.0

BUG-Bruno

@freelon
Copy link
Author

freelon commented Feb 12, 2024

I will check again tomorrow on my work machine, where it worked last time with 1.8.0, but didn't with 1.7.1.

Interestingly I just tried it out on my personal laptop (which runs the same OS) and I don't have the issue there even in 1.7.1. Could it have something to do with the collection involved, the kind of changes, or some dependency of the app that was updated in the meantime (bruno has 6 packages it depends on on Arch)?

@edbrannin
Copy link
Contributor

Possible duplicate of #1396

@freelon
Copy link
Author

freelon commented Feb 14, 2024

I just checked it again on my work machine (bruno 1.8.0) - it works @giemic8

@freelon
Copy link
Author

freelon commented Feb 14, 2024

I have to correct myself - now I do stumble upon the problem again in another request.

One thing I was able to figure out what the difference might be: it works if requests without a BODY were changed. As soon as the request has a body (even if the change is in the URL), it's broken.

@giemic8
Copy link

giemic8 commented Feb 16, 2024

@freelon The issue only exist if you have a json in the body. Maybe this hint will help you.

@esmiralha
Copy link

esmiralha commented Feb 21, 2024

Changing the state of the unsaved item back to the original saved state triggers the issue consistently for me.

Steps to repro:

  • Change the method of a request to a different method
  • the floppy icon becomes orange
  • change the method back to the original method
  • the floppy icon stays orange
  • click the floppy button
  • the save message is displayed
  • the floppy icon stays orange
  • try to close the request tab
  • an unsaved changes message is displayed

@EduardoBrito97
Copy link

Hi, I'm using Bruno 1.19.0, but I still get the same issue.
When I try to close an unsaved request, I click on save and it does nothing -- neither it saves, nor it closes the popup.
2024_07_01_17_09_57_Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants