Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Populate exchange + support for queries with variables #123

Open
andyrichardson opened this issue Dec 3, 2019 · 1 comment
Open

Populate exchange + support for queries with variables #123

andyrichardson opened this issue Dec 3, 2019 · 1 comment
Labels
bug 🐛 Oh no! A bug or unintentional behaviour.

Comments

@andyrichardson
Copy link
Collaborator

Looking to explore how we can extract nodes in a Query document which contain variables (in the populate exchange).

Options:

  • Ignore nodes with variables
  • Auto populate variables with last used values
  • Add a decorator to allow the user to choose what variables to include/exclude .etc

CC @imranolas

@andyrichardson andyrichardson added the discussion 👥 Discussing new features or possible changes to the current behavior or feature set label Dec 3, 2019
@kitten kitten closed this as completed Dec 9, 2019
@andyrichardson
Copy link
Collaborator Author

andyrichardson commented Dec 13, 2019

Going to reopen this as it's still an ongoing issue.

After some discussion, the plan is to remove tracking of nodes which contain variables in the populate exchange. This will prevent issues where @populate returns nodes which have variables which do not exist.

@andyrichardson andyrichardson added bug 🐛 Oh no! A bug or unintentional behaviour. and removed discussion 👥 Discussing new features or possible changes to the current behavior or feature set labels Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 Oh no! A bug or unintentional behaviour.
Projects
None yet
2 participants