Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs on image orientation #233

Open
emirhartato opened this issue Aug 31, 2017 · 1 comment
Open

Bugs on image orientation #233

emirhartato opened this issue Aug 31, 2017 · 1 comment
Assignees
Labels

Comments

@emirhartato
Copy link

emirhartato commented Aug 31, 2017

Problems

Image orientation shows differently on different platform.
Here's the comparison:

  1. Desktop (Safari and Chrome)
    screen shot 2017-08-31 at 12 07 54

  2. iOS (Safari)
    img_0580

  3. Android (Chrome)
    img_0582

How to replicate this issue

  1. Use Telegram for reporting using iOS (iPhone 7) - haven't tried via Twitter
  2. Upload image with portrait orientation
  3. The image will rotated 90 degrees, so I did rotate the image to fix. Apparently it fixed on iOS - but it broke for other platforms.
  4. Upload.

Proposed Solution

  1. Would it possible to put an algorithm for auto-rotate the image into correct orientation - so users doesn't have to fix or rotate manually?

OR

  1. Tweak the image rotation function on the cards.

Any other solutions are welcome.

@emirhartato emirhartato self-assigned this Aug 31, 2017
@matthewberryman
Copy link
Contributor

Going to have to be option 2. Card code for rotation seems to rotate the photo on card display but not actually rotate the uploaded file, c.f.
https://github.com/urbanriskmap/cognicity-cards/blob/master/src/routes/cards/photo/photo.js
Rotating the file before upload, or alternatively adjusting the EXIF and making sure the image-lambda code uses libraries that support EXIF and then rotating the raw image according to EXIF data there, is probably the way to go as support of EXIF orientation is still sketchy (hence variation between iOS and Android).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants