Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of bundle #26

Open
abrahamq opened this issue Jun 28, 2018 · 5 comments
Open

Reduce size of bundle #26

abrahamq opened this issue Jun 28, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@abrahamq
Copy link
Member

vendor bundle is ~7 mb before compression. I don't think tree shaking is working.

@abrahamq abrahamq self-assigned this Jun 28, 2018
@abrahamq
Copy link
Member Author

takes around ~50 seconds on first load using the fastest 4g speed available (1500 kb/s). Super important we fix this before next deployment. No one will stick around for a minute to watch it load.

@abrahamq abrahamq added the bug Something isn't working label Aug 14, 2018
@asbarve
Copy link
Member

asbarve commented Sep 7, 2018

@abrahamq is this still a valid issue?

@abrahamq
Copy link
Member Author

abrahamq commented Sep 7, 2018

Although we've reduced the bundle size to ~4MB combined, it still takes 20 seconds to download on fast 4g and about a minute on 3g. Maybe we should try doing more lazy loading of imports? I'm not really sure how to go about dealing with this.

@abrahamq
Copy link
Member Author

abrahamq commented Sep 7, 2018

We didn't have compression enabled on aws cloudfront. After enabling it, the production size went down 50%. Closing this issue for now. Let's be more careful about adding external dependencies in the future.

@abrahamq abrahamq closed this as completed Sep 7, 2018
@abrahamq
Copy link
Member Author

abrahamq commented Sep 7, 2018

maybe we lazy load the info pane? I'm not sure how else to reduce the size further. Internet says that 40% of people won't wait ~5s for our site to load (best case 4g).

https://angular.io/guide/lazy-loading-ngmodules

@abrahamq abrahamq reopened this Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants