Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are we handling IDs? #4

Open
todrobbins opened this issue Jul 11, 2014 · 3 comments
Open

How are we handling IDs? #4

todrobbins opened this issue Jul 11, 2014 · 3 comments

Comments

@todrobbins
Copy link
Contributor

Since the original list is 1-244 and in alphabetical order, should new additions be added to the bottom of agencies.yml or in alphabetical order starting at agency(245)?

@gbinal
Copy link
Contributor

gbinal commented Jul 12, 2014

I actually think the best move is to remove that numbering altogether - it was included as an artifact in the online csv->yml tool I was using and I wanted to get something up to start working on.

I'm a bit rusty at my regex but can try to remove those numbers and parentheses but if you have a chance and get to it first, please do. In the meantime, I'd suggest adding in new agency additions alphabetically within the file. If you have other acronyms that aren't agencies, we may want to start up other yml files. I'll put in a few placeholders and we can see where it goes.

@gbinal
Copy link
Contributor

gbinal commented Jul 12, 2014

First pass at removing the unnecc. numbers - cb1394e

@todrobbins
Copy link
Contributor Author

@gbinal++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants