Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When getDefinition returns more than 1 result, only the first is displayed #68

Open
hojberg opened this issue Aug 21, 2023 · 1 comment · May be fixed by #90
Open

When getDefinition returns more than 1 result, only the first is displayed #68

hojberg opened this issue Aug 21, 2023 · 1 comment · May be fixed by #90

Comments

@hojberg
Copy link
Member

hojberg commented Aug 21, 2023

When getDefinition returns more than 1 result, we cut a corner and just render the first one in the list. Its rare that you have 2 things named the same, but can occur with smart constructors like in this example from community member Kristian Notari (who reported this issue):

image

We should just render all definitions that were returned, and focus the first one.

@yoching
Copy link
Contributor

yoching commented May 25, 2024

I've been working on this issue.
Please see this branch if you're interested!

https://github.com/yoching/ui-core/tree/fix-multiple-definition

@yoching yoching linked a pull request May 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants