Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused QDTs defined in the BSP Context JSON Schema #3

Open
nissimsan opened this issue Jan 19, 2023 · 5 comments
Open

Unused QDTs defined in the BSP Context JSON Schema #3

nissimsan opened this issue Jan 19, 2023 · 5 comments
Assignees

Comments

@nissimsan
Copy link

@kshychko can you add an example of this, pls?

@kshychko
Copy link

kshychko commented Jan 19, 2023

For example the very first one from QDTs on UNECE-BSPContextCCL.json
which is accessRightsTypeCodeType.
There is one property which seems to be related:

"accessRightsCode": {
          "title": "Requesting_ Party. Access Rights. Code",
          "description": "The code specifying the access rights, such as unlimited, restricted, prohibited, for this requesting party.",
          "uncefact:type": "BasicBIE",
          "uncefact:cefactUNId": "UN01002022",
          "uncefact:cefactBusinessProcess": "Project Management",
          "$ref": "UNECE-BasicComponents.json#/$defs/udt/$defs/codeType"
        }

@kshychko
Copy link

kshychko commented Jan 19, 2023

I assume it should be:

"accessRightsCode": {
          "title": "Requesting_ Party. Access Rights. Code",
          "description": "The code specifying the access rights, such as unlimited, restricted, prohibited, for this requesting party.",
          "uncefact:type": "BasicBIE",
          "uncefact:cefactUNId": "UN01002022",
          "uncefact:cefactBusinessProcess": "Project Management",
           "$ref": "#/$defs/qdt/$defs/accessRightsTypeCodeType",
        }

@nissimsan
Copy link
Author

To be clear, it's the reference which seems bugged:
"$ref": "UNECE-BasicComponents.json#/$defs/udt/$defs/codeType"
pointing at a basic UDT (not QDT).

@kshychko kshychko changed the title Unused QDTs defined in the JSON Schema Unused QDTs defined in the BSP Context JSON Schema Jan 19, 2023
@kshychko
Copy link

kshychko commented Jan 19, 2023

Below is the list of such QDTs which are defined but not used. The number of them is 49 and the total number of QDTs in the current BSP Context JSON Schema is 148.

accessRightsTypeCodeType
accountingAccountBalanceReopeningTypeCodeType
accountingAccountClassificationCodeType
accountingAccountNatureTypeCodeType
accountingAccountStatusCodeType
accountingAmountQualifierCodeType
accountingContactCodeType
accountingDocumentTypeCodeType
accountingEntryCategoryCodeType
accountingEntryLineCategoryCodeType
accountingEntryLineSourceCodeType
accountingEntryProcessingCodeType
accountingJournalCategoryCodeType
accountingJournalCodeType
accountingPeriodFunctionCodeType
accountingPerquisiteCodeType
accountingVoucherMediumCodeType
additionalPostponementCodeType
addressFormatTypeCodeType
alternateCurrencyAmountTypeCodeType
amortizationMethodCodeType
amountWeightTypeCodeType
billingDocumentCodeType
binaryObjectCharacterSetCodeType
binaryObjectEncodingCodeType
cargoTypeClassificationCodeType
certificateTypeCodeType
codeListResponsibleAgencyCodeType
commitmentLevelCodeType
customsProcedureGuaranteeCodeType
dateTimePeriodFunctionCodeType
fileSizeUnitMeasureType
financialAccountTypeCodeType
financialAdjustmentReasonCodeType
financialInstitutionRoleCodeType
invoiceDocumentCodeType
lifetimeEndCostCodeType
mimeCodeType
organizationFunctionTypeCodeType
partyTypeCodeType
quotationDocumentCodeType
refundMethodCodeType
remittanceDocumentCodeType
responseTypeCodeType
scenarioTypeCodeType
schedulingDocumentCodeType
softwareUserTypeCodeType
taxExemptionReasonCodeType
workflowStatusCodeType

@AP-G
Copy link
Contributor

AP-G commented May 6, 2023

Thank you very much for the advice. These have been tackled by the maintenance team after being posted here. Here is a short interim status:
There are then empty code lists (QDTs) if these code lists are maintained externally or, in practice, several code lists can be relevant for the application. This is the case with colours, for example. For colours, for example, there are code lists for RAL colour shades and code lists for Pantone colour shades.
In this case, the QDTs serve as placeholders. They can be easily replaced by the correct code list or extended by the corresponding codes using the procedure described in the JSON Schema NDR.
In such cases, the decision was also sometimes made to refer to the generic code list from the UDTs. The empty code lists then also serve as placeholders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants