Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling/selecting the default blocklist #20

Open
jonasraoni opened this issue Feb 4, 2021 · 2 comments
Open

Allow disabling/selecting the default blocklist #20

jonasraoni opened this issue Feb 4, 2021 · 2 comments

Comments

@jonasraoni
Copy link
Contributor

Maybe the user should be able to disable and/or select a default blocklist (I saw some lists here, perhaps they could be downloaded on demand or added as a submodule).

@ctgraham
Copy link
Member

ctgraham commented Feb 4, 2021

The current approach uses the top10000 from that repo as the default, and then allows the user to add any additional blacklists, always using them all. What this doesn't allow for is for the user to say, "I only want to block the 1000 worst passwords, not the 10000 worst passwords", but that sounds like a bad use-case.

@jonasraoni
Copy link
Contributor Author

Here I just would like to allow the user to easily opt-in for, let's say the top1000000 =]

But it's just a suggestion, if you're going to close this issue, I think it's good to at least display more information about the default blocklist in the settings form (the amount of records/from where it comes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants