Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't upload large file (4GB) #1090

Open
mjtecka opened this issue Dec 5, 2023 · 3 comments
Open

Can't upload large file (4GB) #1090

mjtecka opened this issue Dec 5, 2023 · 3 comments

Comments

@mjtecka
Copy link

mjtecka commented Dec 5, 2023

(ukrepo)

New -> Item
Upload file - 4GB ("myfile", randomly generated from /dev/urandom) - loading went to 2pct and then failed

image
@kosarko
Copy link
Member

kosarko commented Dec 7, 2023

To a degree*, that's expected...

  • we (@mjtecka and me) should agree on a reasonable file size; that a user can upload without going through extra obstacles; and configure the system accordingly. Does 4GB sound reasonable or should it be more?
  • I should add a way to add files above this limit (for admins only)

@milanmajchrak @vidiecan yesterday, you said that an error should be reported right away, if uploading a file above limit. That's not what I'm seeing...the configs are unchanged for now:

/dspace/config# grep -R spring.servlet.multipart.max-
local.cfg.EXAMPLE:#spring.servlet.multipart.max-file-size = 512MB
local.cfg.EXAMPLE:#spring.servlet.multipart.max-request-size = 512MB
clarin-dspace.cfg:spring.servlet.multipart.max-file-size = 4GB
clarin-dspace.cfg:spring.servlet.multipart.max-request-size = 4GB
local.cfg:#spring.servlet.multipart.max-file-size = 512MB
local.cfg:#spring.servlet.multipart.max-request-size = 512MB

I'm testing with a 5G file generated using fallocate as you suggest. The file starts uploading, there's a progress bar, and eventually nginx throws 413 Request Entity Too Large. Is this what you'd expect?

@mjtecka
Copy link
Author

mjtecka commented Dec 8, 2023

We may think about different ways to handle user uploads over some size (for example using API, or some operation involving help by data curator).

Size limit for upload via web interface should be defined, but I think we should be able to handle larger downloads.

@milanmajchrak
Copy link
Collaborator

We discovered that this error occurred due to the Nginx setup. I think we solved it here: dataquest-dev#532

@kosarko kosarko self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants