From e2703687d4314a14026b3b39bbd69f14833b4a37 Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Thu, 11 Apr 2024 14:09:01 -0700 Subject: [PATCH] Add missing mappers for AsyncWorkflowConfiguration --- common/types/mapper/proto/api.go | 6 +++++- common/types/mapper/thrift/shared.go | 2 ++ common/types/testdata/domain.go | 8 ++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/common/types/mapper/proto/api.go b/common/types/mapper/proto/api.go index 161c60d2738..ff04e754b24 100644 --- a/common/types/mapper/proto/api.go +++ b/common/types/mapper/proto/api.go @@ -1082,6 +1082,7 @@ func FromDescribeDomainResponseDomain(t *types.DescribeDomainResponse) *apiv1.Do domain.HistoryArchivalUri = config.HistoryArchivalURI domain.VisibilityArchivalStatus = FromArchivalStatus(config.VisibilityArchivalStatus) domain.VisibilityArchivalUri = config.VisibilityArchivalURI + domain.AsyncWorkflowConfig = FromDomainAsyncWorkflowConfiguraton(config.AsyncWorkflowConfig) } if repl := t.ReplicationConfiguration; repl != nil { domain.ActiveClusterName = repl.ActiveClusterName @@ -1124,6 +1125,7 @@ func ToDescribeDomainResponseDomain(t *apiv1.Domain) *types.DescribeDomainRespon VisibilityArchivalStatus: ToArchivalStatus(t.VisibilityArchivalStatus), VisibilityArchivalURI: t.VisibilityArchivalUri, IsolationGroups: ToIsolationGroupConfig(t.IsolationGroups), + AsyncWorkflowConfig: ToDomainAsyncWorkflowConfiguraton(t.AsyncWorkflowConfig), }, ReplicationConfiguration: &types.DomainReplicationConfiguration{ ActiveClusterName: t.ActiveClusterName, @@ -4303,6 +4305,7 @@ func FromUpdateDomainResponse(t *types.UpdateDomainResponse) *apiv1.UpdateDomain domain.HistoryArchivalUri = config.HistoryArchivalURI domain.VisibilityArchivalStatus = FromArchivalStatus(config.VisibilityArchivalStatus) domain.VisibilityArchivalUri = config.VisibilityArchivalURI + domain.AsyncWorkflowConfig = FromDomainAsyncWorkflowConfiguraton(config.AsyncWorkflowConfig) } if repl := t.ReplicationConfiguration; repl != nil { domain.ActiveClusterName = repl.ActiveClusterName @@ -4334,7 +4337,8 @@ func ToUpdateDomainResponse(t *apiv1.UpdateDomainResponse) *types.UpdateDomainRe HistoryArchivalURI: t.Domain.HistoryArchivalUri, VisibilityArchivalStatus: ToArchivalStatus(t.Domain.VisibilityArchivalStatus), VisibilityArchivalURI: t.Domain.VisibilityArchivalUri, - IsolationGroups: ToIsolationGroupConfig(t.GetDomain().GetIsolationGroups()), + IsolationGroups: ToIsolationGroupConfig(t.Domain.IsolationGroups), + AsyncWorkflowConfig: ToDomainAsyncWorkflowConfiguraton(t.Domain.AsyncWorkflowConfig), }, ReplicationConfiguration: &types.DomainReplicationConfiguration{ ActiveClusterName: t.Domain.ActiveClusterName, diff --git a/common/types/mapper/thrift/shared.go b/common/types/mapper/thrift/shared.go index 56bf9e35bcd..293d162da1c 100644 --- a/common/types/mapper/thrift/shared.go +++ b/common/types/mapper/thrift/shared.go @@ -1874,6 +1874,7 @@ func FromDomainConfiguration(t *types.DomainConfiguration) *shared.DomainConfigu VisibilityArchivalStatus: FromArchivalStatus(t.VisibilityArchivalStatus), VisibilityArchivalURI: &t.VisibilityArchivalURI, Isolationgroups: FromIsolationGroupConfig(t.IsolationGroups), + AsyncWorkflowConfiguration: FromDomainAsyncWorkflowConfiguraton(t.AsyncWorkflowConfig), } } @@ -1891,6 +1892,7 @@ func ToDomainConfiguration(t *shared.DomainConfiguration) *types.DomainConfigura VisibilityArchivalStatus: ToArchivalStatus(t.VisibilityArchivalStatus), VisibilityArchivalURI: t.GetVisibilityArchivalURI(), IsolationGroups: ToIsolationGroupConfig(t.Isolationgroups), + AsyncWorkflowConfig: ToDomainAsyncWorkflowConfiguraton(t.AsyncWorkflowConfiguration), } } diff --git a/common/types/testdata/domain.go b/common/types/testdata/domain.go index 86bb3961f23..f025a2ecb9c 100644 --- a/common/types/testdata/domain.go +++ b/common/types/testdata/domain.go @@ -88,6 +88,14 @@ var ( State: types.IsolationGroupStateDrained, }, }, + AsyncWorkflowConfig: &types.AsyncWorkflowConfiguration{ + Enabled: true, + QueueType: "custom", + QueueConfig: &types.DataBlob{ + EncodingType: types.EncodingTypeThriftRW.Ptr(), + Data: []byte("custom queue config"), + }, + }, } DomainReplicationConfiguration = types.DomainReplicationConfiguration{ ActiveClusterName: ClusterName1,