Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Your generated code uses your own deprecated functions (very minor) #158

Open
RobertoMontagna opened this issue Mar 1, 2024 · 0 comments
Open

Your generated code uses your own deprecated functions (very minor) #158

RobertoMontagna opened this issue Mar 1, 2024 · 0 comments
Assignees
@sywhang
Labels
enhancement

Comments

@RobertoMontagna
Copy link

Very minor thing: but here an example Float64 (same thing for Float32):

CAS deprecated https://github.com/uber-go/atomic/blob/master/float64_ext.go#L49

Use of CAS (same file) https://github.com/uber-go/atomic/blob/master/float64_ext.go#L35

Extra note: CAS is implemented by using the suggested replacement CompareAndSwap

(same file) https://github.com/uber-go/atomic/blob/master/float64_ext.go#L50
@RobertoMontagna RobertoMontagna changed the title Your generated code uses your own deprecated functions Your generated code uses your own deprecated functions (very minor) Mar 1, 2024
@sywhang sywhang self-assigned this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sywhang sywhang

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RobertoMontagna @JacobOaks @sywhang