-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some classes are defined more than once in the same file #23
Comments
On the topic of imports, I do see a few unused imports, but that would be a patch of it's own. I don't know if any of the imports are required as an import side-effect, one would hope not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think in each case the second definition overwrites the initial definition??? at least that is what I would expect.
projects/home/recap/models/config.py
BatchNormConfig is defined twice
DropoutConfig is defined twice
MlpConfig is defined twice
projects/home/recap/embedding/config.py
SmallEmbeddingBagConfig is defined twice
projects/home/recap/model/entrypoint.py
We have two imports stomping eachother out:
The text was updated successfully, but these errors were encountered: