From 12395a6a1d30bd0c6b9c317013b80a3932099a66 Mon Sep 17 00:00:00 2001 From: Spencer Nelson Date: Mon, 16 Dec 2019 13:13:20 -0800 Subject: [PATCH] Obey errcheck -blank in test code --- internal/twirptest/client_test.go | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/internal/twirptest/client_test.go b/internal/twirptest/client_test.go index b3ba4ddc..dce58991 100644 --- a/internal/twirptest/client_test.go +++ b/internal/twirptest/client_test.go @@ -316,7 +316,13 @@ func TestClientWithHooks(t *testing.T) { protoCli := NewHaberdasherProtobufClient(s.URL, &http.Client{}, twirp.WithClientHooks(hooks)) ctx := context.Background() - _, _ = protoCli.MakeHat(ctx, tt.in) + _, err := protoCli.MakeHat(ctx, tt.in) + if tt.wantErrorCalled && err == nil { + t.Error("unexpected nil error") + } + if !tt.wantErrorCalled && err != nil { + t.Errorf("unexpected error: %v", err) + } if tt.wantRequestPreparedCalled != requestPreparedCalled { t.Errorf("unexpected value for requestPreparedCalled: got %t, want %t", requestPreparedCalled, tt.wantRequestPreparedCalled) @@ -335,7 +341,13 @@ func TestClientWithHooks(t *testing.T) { errorCalled = false jsonCli := NewHaberdasherJSONClient(s.URL, &http.Client{}, twirp.WithClientHooks(hooks)) - _, _ = jsonCli.MakeHat(ctx, tt.in) + _, err = jsonCli.MakeHat(ctx, tt.in) + if tt.wantErrorCalled && err == nil { + t.Error("unexpected nil error") + } + if !tt.wantErrorCalled && err != nil { + t.Errorf("unexpected error: %v", err) + } if tt.wantRequestPreparedCalled != requestPreparedCalled { t.Errorf("unexpected value for requestPreparedCalled: got %t, want %t", requestPreparedCalled, tt.wantRequestPreparedCalled)