Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs with horizontal line #3913

Open
1 of 3 tasks
pamelahu opened this issue May 16, 2024 · 2 comments · May be fixed by #4122
Open
1 of 3 tasks

Tabs with horizontal line #3913

pamelahu opened this issue May 16, 2024 · 2 comments · May be fixed by #4122
Labels
Area: Components Related to the component library (core) of this system Fix/Change in Progress DSYS is currently working on a solution and will update the thread with results Type: Bug Something isn't working

Comments

@pamelahu
Copy link

pamelahu commented May 16, 2024

Description

A horizontal line is going through the bottom of the tab.

Example in Paste website:

image

Example with Notification Center that the Console team is trying to develop:

image

Link to Reproduction

https://paste.twilio.design/components/tabs

Steps to reproduce

  1. Visit Tabs in Paste
  2. Zoom in and out at various sizes in the browser; line appears at some zoom %'s

Paste Core Version

8.2.1

Browser

Google Chrome

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

No response

Copy link

dosubot bot commented May 16, 2024

To address the issue of the horizontal line appearing at the bottom of tabs on the Paste website and the Notification Center UI at various browser zoom levels, you can make specific adjustments to the CSS properties related to the bottom border of the tabs. Here's a focused approach to resolve the problem:

  1. Adjust CSS for Selected and Hover States: Modify the borderBottomColor property in the _selected and _hover states of the tabs to transparent. This change aims to eliminate the unwanted horizontal line by ensuring the bottom border blends with the tab background or becomes invisible.
_selected: {
  borderBottomColor: "transparent", // Set to transparent to remove the line
  // Other properties remain unchanged
},
_hover: {
  borderBottomColor: "transparent", // Ensure consistency on hover
  // Other properties remain unchanged
},
  1. Review boxShadow Property: Ensure that the boxShadow property in the _selected state does not create a visual line at the bottom of the tab. Adjust if necessary to avoid any visual artifacts.

  2. Testing and Validation: After implementing these changes, it's crucial to test the tabs across different zoom levels and in various themes (if applicable) to ensure visual consistency and that the issue is resolved.

  3. Visual Regression Testing (VRT): Utilize VRT tools like Chromatic for component snapshots and Percy for documentation site testing to ensure that your changes do not introduce any unintended visual regressions across the system.

By focusing on these targeted adjustments and thoroughly testing the changes, you can effectively resolve the visual issue with the tabs at different browser zoom levels.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@dosubot dosubot bot added Area: Components Related to the component library (core) of this system Type: Bug Something isn't working labels May 16, 2024
@serifluous
Copy link
Member

Thanks for catching this, @pamelahu ! I've added it to our backlog.

@serifluous serifluous added the Fix/Change in Backlog DSYS has acknowledged this improvement and will update the thread with results when we prioritize it label May 21, 2024
@serifluous serifluous added Fix/Change in Progress DSYS is currently working on a solution and will update the thread with results and removed Fix/Change in Backlog DSYS has acknowledged this improvement and will update the thread with results when we prioritize it labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system Fix/Change in Progress DSYS is currently working on a solution and will update the thread with results Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants