Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

fix: firebase config keys exposed to public #270

Open
chroline opened this issue Apr 5, 2020 · 2 comments
Open

fix: firebase config keys exposed to public #270

chroline opened this issue Apr 5, 2020 · 2 comments
Assignees
Labels
category:dev-ops help wanted Extra attention is needed. priority:p1 type:task Tasks are the actions that make up epics.

Comments

@chroline
Copy link

chroline commented Apr 5, 2020

Hello there, great product.

I have a security concern regarding your Firebase configuration and your API keys. Performing a basic search query for "apiKey", I found 176 results for "apiKey" location within the tutorbook repo, which is very concerning.

My recommendation would be to move these configuration details to environment variables so that they aren't publicly visible and available on the public code repository.

@nicholaschiang
Copy link
Member

Good idea! We'll work on this right away.

@nicholaschiang nicholaschiang added category:dev-ops help wanted Extra attention is needed. priority:p1 type:task Tasks are the actions that make up epics. labels Apr 6, 2020
@nicholaschiang nicholaschiang changed the title Firebase config keys exposed to public fix: firebase config keys exposed to public Apr 6, 2020
@dos077
Copy link

dos077 commented Apr 30, 2020

According to the Firebase team themselves, exposing the API key is not a risk. This project seems to run Firebase in a node.js client side app, so the API key will be compiled into plain text in the client side js file, even if it is hidden in the source code. Sure it's easier for maintenance if the API is stored in ENV, but the actual data safe guard relies on GAPI auth to verify user and security setting on the database.

Firebase engineer commented Stackoverflow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
category:dev-ops help wanted Extra attention is needed. priority:p1 type:task Tasks are the actions that make up epics.
Projects
None yet
Development

No branches or pull requests

4 participants