Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow calculation time for IfcSine and IfcCosine #560

Open
Elvira2227 opened this issue Jul 29, 2022 · 1 comment
Open

Slow calculation time for IfcSine and IfcCosine #560

Elvira2227 opened this issue Jul 29, 2022 · 1 comment
Labels
evaluation Assess state of a particular component example-files Issue related to failing reading an example file good first issue Good for newcomers IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement

Comments

@Elvira2227
Copy link
Collaborator

Describe the bug
Calculation of IfcSine and IfcCosine takes a long time.

To Reproduce
Steps to reproduce the behavior:

  1. Go to CurveConverter.h
  2. Scroll down to the line 2693 for IfcSine or to the line 2748 for IfcCosine
  3. Set an additional breakpoint if necessary
  4. Wait for the end of the calculation

CMake configuration
If applicable, list any special configurations you have selected in CMake.

  • EARLYBINDING_WITH_IFC4X3_RC4: selected

Additional context
On my machine it took approximately 9 minutes.
@Elvira2227 Elvira2227 added the bug Something isn't working label Jul 29, 2022
@Elvira2227 Elvira2227 mentioned this issue Jul 29, 2022
Merged
2 tasks
@pjanck pjanck added good first issue Good for newcomers IFC Content related to Industry Foundation Classes (IFC) functionalities evaluation Assess state of a particular component example-files Issue related to failing reading an example file quality_of_life Nice to have improvement and removed bug Something isn't working labels Aug 9, 2022
@Elvira2227 Elvira2227 changed the title [BUG] Slow calculation time for IfcSine and IfcCosine Slow calculation time for IfcSine and IfcCosine Aug 9, 2022
@pjanck
Copy link
Member

pjanck commented Aug 11, 2022

Well that's just how the calculation is organized. Improvements are definitely possible. But I would argue that this currently has a low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
evaluation Assess state of a particular component example-files Issue related to failing reading an example file good first issue Good for newcomers IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjanck @Elvira2227