Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] CurveConverter::convertIfcLoop and subfunctions #528

Open
2 tasks
christophKaiser opened this issue Feb 21, 2022 · 0 comments
Open
2 tasks

[REF] CurveConverter::convertIfcLoop and subfunctions #528

christophKaiser opened this issue Feb 21, 2022 · 0 comments
Assignees
Labels
IFC Content related to Industry Foundation Classes (IFC) functionalities refactoring Code refactoring related task

Comments

@christophKaiser
Copy link
Collaborator

File which is being refactored
OpenInfraPlatform::Core::IfcGeometryConverter::CurveConverterT

Functions

  • (convertIfcLoop - already refactored, just mentioned as 'root'-function)
    • convertIfcPolyLoop (in secondary scope of the intended refactoring, further inspection during refactoring)
    • convertIfcEdgeLoop
      This is one big function, which handles many subtypes. Probably, it will be split into some smaller functions. Furthermore, a few TODOs are in the code.

The need of refactoring the function convertIfcEdgeLoop came up during the implementation of IfcAdvancedFace. I was surprised that the example files in pull request #462 work, even without the existence of functions like convertIfcOrientedEdge, convertIfcEdgeCurve, or convertIfcVertex. These entities are used in the example files. Probably, they are somehow mixed into the function convertIfcEdgeLoop. With refactoring, the structure of convertIfcEdgeLoop should be cleaned up.

@christophKaiser christophKaiser added IFC Content related to Industry Foundation Classes (IFC) functionalities refactoring Code refactoring related task labels Feb 21, 2022
@christophKaiser christophKaiser self-assigned this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IFC Content related to Industry Foundation Classes (IFC) functionalities refactoring Code refactoring related task
Projects
None yet
Development

No branches or pull requests

1 participant