-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dmarc_dns_get_record() calls res_ninit() without zeroing resp first #245
Comments
I could confirm that your patch fixes the crash when the milter was called on the end of the message every times on FreeBSD 14.1-RELEASE. Thank you. (On FreeBSD 14.0-RELEASE, HAVE_RES_NINIT was not defined because of the issue #257) |
nanorkyo
added a commit
to nanorkyo/freebsd-ports
that referenced
this issue
Aug 7, 2024
PR: 279780 Obtained from: trusteddomainproject/OpenDMARC#245 Tested by: leres, John R <[email protected]> Approved by: hrs (mentor), maintainer timeout
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Aug 8, 2024
PR: 279780 Obtained from: trusteddomainproject/OpenDMARC#245 Tested by: leres, John R <[email protected]> Approved by: hrs (mentor), maintainer timeout (6 weeks)
nanorkyo
pushed a commit
to nanorkyo/freebsd-ports
that referenced
this issue
Aug 10, 2024
PR: 279780 Obtained from: trusteddomainproject/OpenDMARC#245 Tested by: leres, John R <[email protected]> Approved by: hrs (mentor), maintainer timeout (6 weeks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation of
res_ninit()
is inconsistent across different operating systems but generally the caller must zero some or all of the argument structure before callingres_ninit()
This is done consistently in
opendmarc_spf_dns.c
(memset before res_ninit) but not inopendmarc_dns.c
:OpenDMARC/libopendmarc/opendmarc_dns.c
Lines 205 to 207 in 9cebf72
I got a burst of crashes a few hours after enabling opendmarc:
evidently due to non-zero stack garbage in the memory used for
resp
. Fix is straightforward:The text was updated successfully, but these errors were encountered: