Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENDMARC_LIB_VERSION no longer contains version information #235

Open
DrRemorse opened this issue Mar 3, 2023 · 1 comment
Open

OPENDMARC_LIB_VERSION no longer contains version information #235

DrRemorse opened this issue Mar 3, 2023 · 1 comment

Comments

@DrRemorse
Copy link

This used to contain version information:

$ grep OPENDMARC_LIB_VERSION /usr/include/opendmarc/dmarc.h
#define OPENDMARC_LIB_VERSION 0x01030200

Now it contains 0x00000000. Can you check to see if perhaps a version number generator is not working?

I am currently using the following logic and hope version numbers are supported again in the future:

#if (OPENDMARC_LIB_VERSION >= 0x01040000L) || (OPENDMARC_LIB_VERSION == 0x00000000L)
s = opendmarc_policy_store_dkim(dmarc, domain, selector, dkim_to_dmarc(r), comment);
#else
s = opendmarc_policy_store_dkim(dmarc, domain, dkim_to_dmarc(r), comment);
#endif

Thank you!

@kjc75
Copy link

kjc75 commented Mar 3, 2023

Appears this used to be set as part of the dist-hook Makefile target, but that's not getting triggered via the GitHub release process, and winds up remaining the default 0. I don't see it set in any of the 1.4 release packages on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants