Pre-push hook #1910
Unanswered
svalexander
asked this question in
Q&A
Pre-push hook
#1910
Replies: 1 comment 1 reply
-
@svalexander Hi! I'm sorry, I didn't see this discussion at all (I think you're the first to use Discussions for this repo!). I see that you figured it out and created #1911. Did you figure out what the issue you were facing was? In case it happens to others in the future, I'd love for us to be able to be aware of it and potentially do something to address it. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, I've forked the repo in order to push up my local branch for issue #1619 and then create a pr from it. When I try to push it fails b/c there's an error when the pre-push hook is run. Running "yarn danger local" in the CLI I can see the issue better - localGetDiff throws an error. The error is as follows: Could not get diff from git between master and HEAD.
From the contributing documentation I see that any changes to Storybook are automatically checked in Happo.io. Am I correct in assuming b/c I've added a story the pre-push hook is failing as my local diff doesn't match what's in Happo? And how do I proceed? Is it best to bypass the hook?
Just going to tag a few contributors randomly on this, not sure who checks the repo regularly for discussions. @ahobson @brandonlenz @haworku @tinyels
Beta Was this translation helpful? Give feedback.
All reactions