Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong arrays passed to interpolation #547

Open
efaulhaber opened this issue Jun 19, 2024 · 0 comments
Open

Fix wrong arrays passed to interpolation #547

efaulhaber opened this issue Jun 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@efaulhaber
Copy link
Member

In #462 and the dam break validation, v and u are passed to the interpolation instead of v_ode and u_ode. This is not correct, and it only works when the system is the first one in the semidiscretization.
We need to fix this once #424 is resolved.

I thought I already created an issue for this, but I can't find it now.
@svchb svchb added the bug Something isn't working label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svchb @efaulhaber