Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we move long hard-coded coordinate arrays in the test files to separate files? #490

Open
efaulhaber opened this issue Apr 2, 2024 · 3 comments

Comments

@efaulhaber
Copy link
Member

efaulhaber commented Apr 2, 2024

Hm, we also hard code the coordinates for the RectangularTank tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this?

On the other hand, it's a good point to put coordinates for setup tests in a separate csv file...

Originally posted by @LasNikas in #437 (comment)

@efaulhaber efaulhaber changed the title Hm, we also hard code the coordinates for the RectangularTank tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this? Shall we move long hard-coded coordinate arrays in the test files to separate files? Apr 2, 2024
@efaulhaber
Copy link
Member Author

A quick thought on this: Most of these long arrays are three-liners, right? So when reading it in an editor without line-wrapping, it's just three lines that one can easily ignore.

@LasNikas
Copy link
Collaborator

LasNikas commented Apr 2, 2024

A quick thought on this: Most of these long arrays are three-liners, right? So when reading it in an editor without line-wrapping, it's just three lines that one can easily ignore.

yes:

image

@svchb
Copy link
Collaborator

svchb commented Apr 3, 2024

This depends on the array some will be formatted in a way that they will follow the 90 char length limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants