Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Trixi.jl versions < 0.9? #43

Open
tristanmontoya opened this issue Oct 17, 2024 · 2 comments
Open

Support for Trixi.jl versions < 0.9? #43

tristanmontoya opened this issue Oct 17, 2024 · 2 comments

Comments

@tristanmontoya
Copy link
Member

tristanmontoya commented Oct 17, 2024 •
edited
Loading

In trixi-framework/Trixi.jl#2037, the unused parameter initial_condition was removed from rhs!. In my implementation of a new rhs! method for the covariant solver in #31, should I have a second version that takes initial_condition to maintain compatibility with older Trixi.jl versions? Or should we just change the compat in Project.toml to only be 0.9? I have no problem either way but I was wondering if there's any good reason to support such earlier versions of Trixi.jl.
@benegee
Copy link
Collaborator

benegee commented Oct 17, 2024

Perfectly fine with me!
As long as we do not have any releases, there seems to be no reason to be backward compatible.

@ranocha
Copy link
Member

ranocha commented Oct 17, 2024 •
edited
Loading

Yes, I agree - just update the compatibility section of the Project.toml file accordingly and restrict the development here to the new version of Trixi.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ranocha @tristanmontoya @benegee