Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Trixi to 0.9 for package test, (keep existing compat) #42

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Trixi package from 0.7, 0.8 to 0.7, 0.8, 0.9 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@benegee benegee force-pushed the compathelper/new_version/2024-10-11-00-27-09-312-04156794141 branch from 83d08fd to c71b760 Compare October 11, 2024 00:27
@ranocha
Copy link
Member

ranocha commented Oct 11, 2024

Since #41 has already been merged, CI should work. However, it is better to merge several CompatHelper PRs first into a single PR to really check whether CI passes before merging stuff into main.

@ranocha ranocha enabled auto-merge (squash) October 11, 2024 06:41
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (20c9ebd) to head (f624b39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files           8        8           
  Lines         829      829           
=======================================
  Hits          678      678           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha merged commit 7079c44 into main Oct 11, 2024
10 checks passed
@ranocha ranocha deleted the compathelper/new_version/2024-10-11-00-27-09-312-04156794141 branch October 11, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant