Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up testing/CI and other basic package infrastructure #3

Open
13 of 14 tasks
sloede opened this issue Jul 8, 2024 · 5 comments
Open
13 of 14 tasks

Set up testing/CI and other basic package infrastructure #3

sloede opened this issue Jul 8, 2024 · 5 comments
Assignees

Comments

@sloede
Copy link
Member

sloede commented Jul 8, 2024

[...] we should perhaps set up testing/CI (similarly to TrixiShallowWater.jl) before merging this to main.

Originally posted by @tristanmontoya in #2 (comment)

List of things to set up (feel free to amend/check off):

  • A basic Julia test setup (test/runtests.jl and friends, based on functionality in TrixiBase.jl)
  • CI: testing (.github/workflows/ci.yml)
  • Documenter: add Documenter key to GitHub repository secrets
  • CI: Documenter
  • CI: CompatHelper
  • CI: TagBot
  • Add .JuliaFormatter file (format #5)
  • CI: FormatCheck (format #5)
  • CI: SpellCheck (5dd0e57)
  • CI: Dependabot (0b417e8)
  • Codecov: enable repository in GitHub org settings
  • Zenodo: enable repository for DOI retrieval
  • Add badges to README: docs, license, DOI etc.
  • Downstream CI tests for Trixi.jl
@sloede
Copy link
Member Author

sloede commented Jul 8, 2024

IMHO this is an excellent suggestion @tristanmontoya!

I've added some of the things that I recommend to get right up front, before starting to consider true content additions, to the OP above ☝️

Most of these things can be found in TrixiShallowWater.jl, a good place to get started is maybe this early state where a lot of the above-mentioned points are already in but not much else yet:
https://github.com/trixi-framework/TrixiShallowWater.jl/tree/c1cad34a12a4e17c716601292042107925a89886

The advantage of setting up these things first is that test turnaround times are much faster now, which helps to get everything right. I even recommend to temporarily remove Trixi.jl from this package's dependencies such that you can avoid the precompilation time during CI runs while testing everything.

Feel free to ping me in case of questions.

@tristanmontoya
Copy link
Member

tristanmontoya commented Jul 19, 2024

It seems like the CI badge sometimes says "failing" even when the default branch passes. I think it may be reporting the status of failing CI runs triggered by a PR. I tried adding ?branch=main following this tutorial, but the badge just changed to "no status" and I ended up changing it back.

@benegee
Copy link
Collaborator

benegee commented Jul 23, 2024

Well spotted!

Maybe our URL scheme is outdated? And maybe the branch defaults to main?

Scheme as used in current Trixi.jl README

Trixi.jl

Trixi.jl main

Trixi.jl feature-t8codemesh-checkpointing

TrixiAtmo.jl

TrixiAtmo.jl main

TrixiAtmo.jl bg/moist-equations-lucas

Scheme as used in the docs

Trixi.jl

Trixi.jl main

Trixi.jl feature-t8codemesh-checkpointing

TrixiAtmo.jl

TrixiAtmo.jl main

TrixiAtmo.jl bg/moist-equations-lucas

@tristanmontoya
Copy link
Member

Thanks for looking into that, I didn't catch that the rest of the URL was different! I think it makes sense to change the TrixiAtmo.jl one to https://github.com/trixi-framework/TrixiAtmo.jl/actions/workflows/ci.yml/badge.svg, and it should probably be changed similarly in Trixi.jl too (unless the Trixi devs have a reason for keeping the old URL scheme).

@benegee
Copy link
Collaborator

benegee commented Jul 23, 2024

I think we should not run tests with coverage and upload the coverage data for ubuntu, macos, and windows. It seem to cause errors like

Response: {"message":"Can't add a job to a build that is already closed. Build 10060164422 is closed. See docs.coveralls.io/parallel-builds","error":true}`

Maybe we should do coverage testing for the ubuntu run only, in case we in general want to do testing for MacOS and Windows as well. @tristanmontoya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants