Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes #288

Merged
merged 16 commits into from
Jan 31, 2024
Merged

Misc bug fixes #288

merged 16 commits into from
Jan 31, 2024

Conversation

@amaanq amaanq changed the base branch from fixes to master January 31, 2024 09:41
@amaanq amaanq merged commit 248303d into tree-sitter:master Jan 31, 2024
5 checks passed
@vird
Copy link

vird commented Jan 31, 2024

Can I ask you release node-tree-sitter with up to date tree-sitter (0.20.9)?

String.prototype.isUpperCase = function() {

(\n is important, and number of characters in property names are important)
works with tree-sitter-cli (ERROR is expected)
But with tree-sitter 0.20.6 is not working

#!/usr/bin/env node
Parser = require("tree-sitter")
ts_js  = require("tree-sitter-javascript")
parser = new Parser().setLanguage(ts_js)
code = "String.prototype.isUpperCase = function() {\n"
parser.parse(code)

Causes Segmentation fault (core dumped)

N.b. I tried to fix it with newer tree-sitter but no luck with install from github:tree-sitter/tree-sitter https://github.com/hu2prod/node-tree-sitter/blob/master/package.json#L31

@amaanq
Copy link
Member Author

amaanq commented Jan 31, 2024

I'll get to it when I can, catching up with a lot of tree-sitter stuff atm - so hopefully within a week or two

grammar.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment