Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to C++20 prevents usage on Ubuntu 20.04 with Node.js <= 20 #232

Open
segevfiner opened this issue Nov 3, 2024 · 2 comments
Open

Bump to C++20 prevents usage on Ubuntu 20.04 with Node.js <= 20 #232

segevfiner opened this issue Nov 3, 2024 · 2 comments

Comments

@segevfiner
Copy link
Contributor

segevfiner commented Nov 3, 2024

Node.js <= 20 minimum OS is Ubuntu 20.04, but this package has moved to C++20 which is unsupported on Ubuntu 20.04, which leads to tree-sitter/workflows#16

That is, the official workflows to build grammars fail on Ubuntu 20.04 due to this if node-tree-sitter is upgrade to 0.22.0.

@ObserverOfTime
Copy link
Member

ObserverOfTime commented Nov 3, 2024

The bump came after the breakage.
As far as I can tell, Node 23 uses C++20 and node-gyp uses that instead of the running version for whatever reason.

@segevfiner
Copy link
Contributor Author

That's prebuildify defaulting to the latest Node.js version for building node-api packages, we will also need to add --target to its invocation with an older version like 20.18.0 that uses C++17. (And also tree-sitter itself not requiring C++20 for this to work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants