Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to Set Individual LED RGB Color (command: 'n') for mk2 Devices #680

Open
vt128 opened this issue Sep 28, 2023 · 1 comment
Open

Fail to Set Individual LED RGB Color (command: 'n') for mk2 Devices #680

vt128 opened this issue Sep 28, 2023 · 1 comment

Comments

@vt128
Copy link

vt128 commented Sep 28, 2023

Hi Tod,

I've encountered a problem while attempting to set the RGB color of individual LEDs using the Set RGB color now command detailed in the HID command documentation. The command format I've been utilizing is { 1, 'n', r, g, b, 0, 0, n } (*).

My observation is that attempting to set the color of a specific LED (i.e. n > 0, n in the byte[7]) leads to an issue where all the LEDs switch to white ⚪, disregarding the provided RGB values. This issue persists no matter the individual RGB values I input. Interestingly, when I set the LED number (n) to 0, the command correctly sets all LEDs to the specified color.

Upon inspecting the corresponding code block of the mk2 firmware (located here), I discovered that the LedN > 0 case steers to the method setLED( c.r, c.g, c.b, ledn );. I'm unable to identify the definition of the setLED method in the current codebase (maybe I didn't find the correct file 😢).

Could you please tell me know if this is a bug 🐛 or by design?

@vt128
Copy link
Author

vt128 commented Sep 28, 2023

I would like to also mention a related observation concerning the CLI tool implementation. I noticed that in this section of the code, the arguments for ledn appear to be overlooked entirely. I am curious to know if there is a specific reason for this implementation, as it may provide some insight into the issues experienced with the Set RGB color now command in the mk2 firmware.

Look forward to your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant