Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crf_pubmed_rct config #18

Open
preetraga opened this issue Jan 12, 2019 · 1 comment
Open

crf_pubmed_rct config #18

preetraga opened this issue Jan 12, 2019 · 1 comment

Comments

@preetraga
Copy link

Should crf_pubmed_rct.json have

"classifier_feedforward": {
"input_dim": 600,
"num_layers": 2,
"hidden_dims": [300, 5],
"activations": ["relu", "linear"],
"dropout": [0.2, 0.0]
}

The config. runs only after removing this; otherwise it gives an error: allennlp.common.checks.ConfigurationError: "Extra parameters passed to DiscourseCrfClassifier:

Also, do any of the config json files correspond to a Bi LSTM CRF? They seem to be either a Bi-LSTM or a CRF?

@titipata
Copy link
Owner

@preetraga thanks for the catch, we should remove

"classifier_feedforward": {
"input_dim": 600,
"num_layers": 2,
"hidden_dims": [300, 5],
"activations": ["relu", "linear"],
"dropout": [0.2, 0.0]
}

since we already do a feed forward right after Bi-LSTM of sequence of sentences using label_projection_layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants