Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lint and warning checks #33

Open
eschrock opened this issue Sep 27, 2019 · 2 comments
Open

add lint and warning checks #33

eschrock opened this issue Sep 27, 2019 · 2 comments
Labels
Priority: Normal Issues to be address during sprint Type: Feature New feature or request

Comments

@eschrock
Copy link
Contributor

Problem

We <3 clean code. In titan-server we run ktlint, and treat all warnings as error, to create a consistent style and expectations. We should do the same in the CLI.

Solution

Set the appropriate flags to treat warnings as errors, and add ktlint. See titan-server, though the mechanics will be difference since it's maven and not gradle.

Alternatives

Live with unclean code.

@eschrock eschrock added the Type: Feature New feature or request label Sep 27, 2019
@mcred mcred added the Priority: Normal Issues to be address during sprint label Oct 3, 2019
@mcred
Copy link
Collaborator

mcred commented Dec 12, 2019

Was this resolved with #111?

@eschrock
Copy link
Contributor Author

I added lint, but warnings still abound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Normal Issues to be address during sprint Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants