Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasip1 syscall package needs syscall.FDFLAG_NONBLOCK #4491

Open
dgryski opened this issue Oct 2, 2024 · 1 comment
Open

wasip1 syscall package needs syscall.FDFLAG_NONBLOCK #4491

dgryski opened this issue Oct 2, 2024 · 1 comment

Comments

@dgryski
Copy link
Member

dgryski commented Oct 2, 2024

Go's internal/syscall/unix package expects it, and is needed for some tests

~ $ tinygo test -target=wasip1 mime/multipart
FAIL	mime/multipart	0.000s
# internal/syscall/unix
/Users/dgryski/go/src/go.googlesource.com/go/src/internal/syscall/unix/nonblocking_wasip1.go:19:23: undefined: syscall.FDFLAG_NONBLOCK
/Users/dgryski/go/src/go.googlesource.com/go/src/internal/syscall/unix/nonblocking_wasip1.go:23:22: undefined: syscall.FDFLAG_NONBLOCK
~ $ tinygo test -target=wasip1 net/mail
FAIL	net/mail	0.000s
# internal/syscall/unix
/Users/dgryski/go/src/go.googlesource.com/go/src/internal/syscall/unix/nonblocking_wasip1.go:19:23: undefined: syscall.FDFLAG_NONBLOCK
/Users/dgryski/go/src/go.googlesource.com/go/src/internal/syscall/unix/nonblocking_wasip1.go:23:22: undefined: syscall.FDFLAG_NONBLOCK
~ $ tinygo test -target=wasip1 net/textproto
FAIL	net/textproto	0.000s
# internal/syscall/unix
/Users/dgryski/go/src/go.googlesource.com/go/src/internal/syscall/unix/nonblocking_wasip1.go:19:23: undefined: syscall.FDFLAG_NONBLOCK
/Users/dgryski/go/src/go.googlesource.com/go/src/internal/syscall/unix/nonblocking_wasip1.go:23:22: undefined: syscall.FDFLAG_NONBLOCK
@aykevl
Copy link
Member

aykevl commented Oct 2, 2024

I was actually changing some targets over to use the Go stdlib syscall package instead. That would probably solve this issue.
See: #4461 for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants