Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode causal timestamp in storage module for RawKV APIV2 #13284

Closed
3 tasks done
haojinming opened this issue Aug 15, 2022 · 1 comment
Closed
3 tasks done

Encode causal timestamp in storage module for RawKV APIV2 #13284

haojinming opened this issue Aug 15, 2022 · 1 comment
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@haojinming
Copy link
Contributor

haojinming commented Aug 15, 2022

Development Task

Encode ts in storage module can benifit from following aspects:

  1. Compatible with solution of issue: supporting using more efficient format for put/delete requests #12020
  2. Resolved the rawkv cdc issue, that when propose failed, there may be dead lock in resolved_ts, which is currently resolved by dead lock detection in
    fn handle_raw_outlier_regions(
  3. Helpful to implement stale read in rawkv, ref : Stale read for rawkv with read ts rfcs#96.

To implement this, we need three PRs to achieve it:

@haojinming haojinming added the type/enhancement The issue or PR belongs to an enhancement. label Aug 15, 2022
@haojinming haojinming self-assigned this Aug 15, 2022
ti-chi-bot added a commit that referenced this issue Aug 22, 2022
fengou1 pushed a commit to fengou1/tikv that referenced this issue Aug 30, 2022
ref tikv#13284

Signed-off-by: haojinming <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Signed-off-by: fengou1 <[email protected]>
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
…13326)

ref #13284

1. Encode ts in storage for raw modify interface
2. Use concurrency manager to lock rawkv ts to get rawkv  resolved_ts in cdc.
3. Remove append ts in CausalObserver
4. Remove track/untrack raw ts in cdc scheduler. Will remove code in next PR as it make pr too big to review.

Signed-off-by: haojinming <[email protected]>

Co-authored-by: Ping Yu <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot pushed a commit that referenced this issue Sep 23, 2022
@haojinming
Copy link
Contributor Author

haojinming commented Sep 23, 2022

All PRs are merged in master branch. But there is still one issue unfixed: #13502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant