scheduler: replace pauseLeader with two flags and add source filter to transferIn #8623
Conversation
…o transferIn Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XL
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8623 +/- ##
==========================================
- Coverage 77.63% 77.58% -0.05%
==========================================
Files 474 474
Lines 62097 62137 +40
==========================================
+ Hits 48209 48212 +3
- Misses 10340 10376 +36
- Partials 3548 3549 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
pkg/core/basic_cluster.go
Outdated
| @@ -137,8 +137,10 @@ type StoreSetInformer interface { | |||
|
|
|||
| // StoreSetController is used to control stores' status. | |||
| type StoreSetController interface { | |||
| PauseLeaderTransfer(id uint64) error | |||
| ResumeLeaderTransfer(id uint64) | |||
| PauseLeaderTransferIn(id uint64) error | |||
There was a problem hiding this comment.
Is it something like PauseLeaderTransferIn(id uint64, d direction) error
pkg/schedule/schedulers/utils.go
Outdated
| // pauseAndResumeLeaderTransfer checks the old and new store IDs, and pause or resume the leader transfer. | ||
| func pauseAndResumeLeaderTransfer[T any](cluster *core.BasicCluster, old, new map[uint64]T) { | ||
| // pauseAndResumeLeaderTransferIn checks the old and new store IDs, and pause or resume the leader transfer in. | ||
| func pauseAndResumeLeaderTransferIn[T any](cluster *core.BasicCluster, old, new map[uint64]T) { |
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
size/L
ti-chi-bot
bot
added
size/XL
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: Close #8621
What is changed and how does it work?
Check List
Tests
Before this pr:
After this pr:
Release note