-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for new AgateIterator interface #63
Comments
Returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The iterator trait can panic due to incorrect usage. I propose a safer design:
KeyValuePair
trait allows customization of key and value, so it's still lazily loaded. Andkey
andvalue
methods will not have to check for valid any more. Iterator doesn't have to store the error either.This interface is for future refactor, doesn't have to be implemented in this PR.
Originally posted by @BusyJay in #30 (comment)
The text was updated successfully, but these errors were encountered: