EntityBase “requestSpeedChangeWithConstantAcceleration” and “requestSpeedChange” sometimes will not throw an error

[gmajrobotec]

Description

Location: enetity_base.cpp: 305, 394, 457

Function isTargetSpeedReached throws an error from speed_change.cpp:47 if it is provided with an invalid entity name in the speed_change::RelativeTargetSpeed argument.
There are several places in requestSpeedChange functions where isTargetSpeedReached is invoked if-and-only-if continuous == false (early return). This means that an invalid speed_change::RelativeTargetSpeed argument will sometimes result in an error immediately, but sometimes will not.
Note that the error will be thrown eventually anyway (might remove this, as it is not technically an issue).

Solution
This could be changed by inverting the order of statements in the if (!continuous && isTargetSpeedReached(target_speed)) statement. However as noted above, this is only a suggestion and can be removed.

[hakuturu583]

Invalid operation should not be permitted, so if the speed_change::RelativeTargetSpeed called with invalid name, it should throw exception.