-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plumbing post-processing for survival analysis #229
Comments
More thoughts from Hannah in a follow-up comment on the same PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From Hannah in the linked discussion:
Okay so here are my thoughts on what plumbing post-processing for survival analysis would need.
Basic assumptions
eval_time
our old friend).I have not yet validated either assumption. Max, do you have a sense of whether they are valid?
For the implementation, this implies
eval_time
?Specifying the predictions
tailor()
could take survival time.pred_time
via theestimate
argument -- the documentation already suggest that.tailor()
could take survival probability in the tibble form of.pred
(containing.eval_time
and.pred_survival
) via theprobabilities
argument.Specifying
eval_time
tailor()
would droptime
(the documentation for that as "the predicted event time" contradicts the documentation forestimate
listing.pred_time
) and instead takeeval_time
. The alternative would be to derive it from.pred
within a given postprocessingoperation
and default to the first value if we need a single one. Either way,time
would disappear.eval_time
topredict()
andaugment()
methods for workflows but since we currently don't need it earlier, there are not arguments for eval time to thefit()
method for workflows or the specification viaworkflow()
.predict.workflow()
having aneval_time
argument should be fine.tailor()
specification.eval_time
argument which is required for dynamic and integrated survival metrics. If we need a single eval time to optimize for, we use the first one.eval_time
twice: when making thetailor()
and when calling the tuning function.Originally posted by @hfrick in #225 (review)
The text was updated successfully, but these errors were encountered: