Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate_stop() for surv_reg() #1206

Open
hfrick opened this issue Sep 20, 2024 · 1 comment
Open

deprecate_stop() for surv_reg() #1206

hfrick opened this issue Sep 20, 2024 · 1 comment
Labels
upkeep maintenance, infrastructure, and similar

Comments

@hfrick
Copy link
Member

hfrick commented Sep 20, 2024

How long do we want to have surv_reg() sit in the warning stage of the deprecation? It's been warning on CRAN since Apr 12, 2023, so over a year now. Do we typically give people longer than that?

History:

  • deprecate_warn() since Mar 30, 2023 on dev, released in parsnip 1.1.0 on Apr 12, 2023
  • deprecate_soft() since Mar 23, 2021 on dev
@hfrick hfrick added the upkeep maintenance, infrastructure, and similar label Sep 20, 2024
@simonpcouch
Copy link
Contributor

I support transitioning to deprecate_stop!👍

@hfrick hfrick mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hfrick @simonpcouch