Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: module: refresh after action button action #2171

Open
3 tasks done
backslashxx opened this issue Oct 31, 2024 · 5 comments
Open
3 tasks done

manager: module: refresh after action button action #2171

backslashxx opened this issue Oct 31, 2024 · 5 comments

Comments

@backslashxx
Copy link
Contributor

backslashxx commented Oct 31, 2024

Please check before submitting an issue

  • I have searched the issues and haven't found anything relevant
  • I will upload bugreport file in KernelSU Manager - Settings - Report log
  • I know how to reproduce the issue which may not be specific to my device

Describe the bug

user has to pull down to refresh after action button action
some modules use description ie on module.prop to show status

To Reproduce

https://github.com/backslashxx/bindhosts/blob/4e7ba03e0576b0e0bceac5c1ba4f1d2f3260814c/action.sh#L98

  • this part where description gets updated

Screenshots

bindhosts.mp4

Expected behavior

Module manager refreshes itself

ScreenRecord-2024-10-31-10-29-56.mp4

Logs

irrelevant

Device info

Additional context

No response

@rsuntk
Copy link
Contributor

rsuntk commented Oct 31, 2024

Maybe creating a refresh function after action button was pressed is a good idea.

@backslashxx
Copy link
Contributor Author

backslashxx commented Oct 31, 2024

Maybe creating a refresh function after action button was pressed is a good idea.

it gets refreshed on module updates/customize.sh triggers but not on action
ofcourse this is also on downstream, Apatch
magisk behavior refreshes it auto as seen on top

ig i'll tag this guy
#2156

@rsuntk
Copy link
Contributor

rsuntk commented Oct 31, 2024

it gets refreshed on module updates/customize.sh triggers but not on action
ofcourse this is also on downstream, Apatch

Apatch refreshed by default?

@backslashxx backslashxx changed the title Module manager, refresh after action button action manager: module: refresh after action button action Oct 31, 2024
@backslashxx
Copy link
Contributor Author

backslashxx commented Oct 31, 2024

@rsuntk

video4979156883332924608.mp4

seems same bug on Apatch
maybe thats where I should report this as the change came from them according to #2156

@rsuntk
Copy link
Contributor

rsuntk commented Oct 31, 2024

Modify onBack function maybe can fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants