Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for cases where included Thrift files name conflict with library imports #88

Open
abhinav opened this issue Mar 29, 2016 · 0 comments

Comments

@abhinav
Copy link
Contributor

abhinav commented Mar 29, 2016

I'm fairly sure we already handle this correctly, but we need a couple explicit tests for cases like these:

import (
    "fmt"

    "my/generated/code/fmt"  // generated from fmt.thrift
)

We should be doing a qualified import in these cases:

import (
    "fmt"

   fmt2  "my/generated/code/fmt"  // generated from fmt.thrift
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant