Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field annotations are not properly being set for plugin handlers #429

Open
dmtsui opened this issue Nov 26, 2019 · 0 comments
Open

Field annotations are not properly being set for plugin handlers #429

dmtsui opened this issue Nov 26, 2019 · 0 comments

Comments

@dmtsui
Copy link
Contributor

dmtsui commented Nov 26, 2019

Annotations on fields for functions such as arguments and exceptions are not properly set for plugin usage. in compile/field.go annotations are set on the FieldSpec's Annotation property, but when generating the service request for plugin handlers, annotations for fields are read from the FieldSpec.Type which has no annotations. This leads to an issue of annotations on fields not being available for plugins when they are properly being added to a thrift file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant