Subscriptions: Respect DisableAssetWebsocketSupport for assets #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbjk
changed the title
shazbert
requested changes
Oct 27, 2024
gbjk
force-pushed
the
bugfix/1692_bitmex
branch
from
da3ffc9
to
939e766
Compare
|
Rebased |
gbjk
commented
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
+ Coverage 36.95% 36.98% +0.03%
==========================================
Files 414 414
Lines 180443 180447 +4
==========================================
+ Hits 66677 66735 +58
+ Misses 105923 105872 -51
+ Partials 7843 7840 -3
|
gbjk
force-pushed
the
bugfix/1692_bitmex
branch
from
feed889
to
e58f029
Compare
| at := e.GetAssetTypes(true) | ||
| at := []asset.Item{} | ||
| for _, a := range e.GetAssetTypes(true) { | ||
| if e.IsAssetWebsocketSupported(a) { |
There was a problem hiding this comment.
With only Index asset enabled
Only trade sub enabled:
{
"enabled": true,
"channel": "trade",
"asset": "all"
},
[ERROR] | WEBSOCKET | 14/11/2024 11:49:43 | Bitmex websocket: subscription failure, trade all : subscription template did not generate the expected number of asset records: Got 1; Expected 0
Do you classify this as something to address?
There was a problem hiding this comment.
Absolutely. That's a bug in the sub template (which I've made a few times now).
I'll fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscriptions:
Bitmex:
Fixes #1692
Type of change
How has this been tested
TestGenerateSubscriptionscovers the requirement, once index was added to configtest