Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_repo.revision = "v$SOME_ENV_VAR" #3277

Open
Dmitry-N-Medvedev opened this issue Oct 15, 2024 · 1 comment
Open

github_repo.revision = "v$SOME_ENV_VAR" #3277

Dmitry-N-Medvedev opened this issue Oct 15, 2024 · 1 comment

Comments

@Dmitry-N-Medvedev
Copy link

good morning, nice community!

Looks like there is no string extrapolation in the revision field of the github_repo:

.plzconfig

[BuildEnv]
FLATBUFFERS-VERSION = 24.3.25

BUILD

github_repo(
  name = "flatbuffers_src",
  repo = "google/flatbuffers",
  revision = "v$FLATBUFFERS_VERSION",
)
@Dmitry-N-Medvedev
Copy link
Author

For the uninitiated like me, this solution will work:

.plzconfig

[Buildconfig]
FLATBUFFERS-VERSION = 24.3.25

BUILD

github_repo(
  name = "flatbuffers_src",
  repo = "google/flatbuffers",
  revision = f"v{CONFIG.FLATBUFFERS_VERSION}",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant