Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixup between expected and actual checksum #3228

Open
tm-jdelapuente opened this issue Aug 19, 2024 · 1 comment
Open

Mixup between expected and actual checksum #3228

tm-jdelapuente opened this issue Aug 19, 2024 · 1 comment

Comments

@tm-jdelapuente
Copy link
Contributor

After upgrading Please to 17.10.1 in .plzconfig with the hash of 17.9.0 (87724be4995cc0385b18eea05feb23c8672ab9817bd484401f2d1053e1117325) I ran and got

$ plz update --force
17:17:09.161 CRITICAL: Failed to download Please: Invalid checksum of downloaded file, was f5436a2f265f7cf905f384e74db9453bc9d012078273136c8c1452bff2ddb85e, expected 87724be4995cc0385b18eea05feb23c8672ab9817bd484401f2d1053e1117325

Problem: the hashes are the other way around - the expected is the actual and vice versa

@toastwaffle
Copy link
Contributor

I think the behaviour is correct - according to the config we expecting the hash to be 87724b..., but when we downloaded Please the hash we got for the download was f5436a...

You could make the message more explicit, along the lines of downloaded file had hash ..., but hash expected in .plzconfig is ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants