Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search functionality to docs website #3192

Open
mauriceyap opened this issue Jul 5, 2024 · 1 comment · May be fixed by #3207
Open

Add search functionality to docs website #3192

mauriceyap opened this issue Jul 5, 2024 · 1 comment · May be fixed by #3207
Assignees
@mauriceyap
Labels
documentation enhancement

Comments

@mauriceyap
Copy link
Member

The Please website does not currently provide a way to search for content across the site. Using Google search is an option to achieve this, but it is inelegant and relies on its cache.

The idea is to implement content search on the client side, in keeping with the architecture of the existing simple static site.
@mauriceyap mauriceyap self-assigned this Jul 5, 2024
@mauriceyap mauriceyap linked a pull request Jul 6, 2024 that will close this issue
Add id attributes to all h1 and h2 tags in docs site #3194
Merged
@mauriceyap mauriceyap removed a link to a pull request Jul 6, 2024
Add id attributes to all h1 and h2 tags in docs site #3194
Merged
@peterebden
Copy link
Member

I'm not clear why we want to build this ourselves - it feels a lot lower effort to leverage Google, I wouldn't describe that as inelegant.
Maybe it's nice to have something on the site to search directly, but it's easy enough for that to just link back to Google with a site:please.build search

@peterebden peterebden mentioned this issue Jul 11, 2024
Open
@peterebden peterebden linked a pull request Aug 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauriceyap mauriceyap

Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
2 participants
@peterebden @mauriceyap