-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined symbols: dynv::types::xml::write #222
Comments
This is fixed by commit f4c8adc in master branch and version 0.3 requires similar changes: --- source/dynv/Xml.cpp
+++ source/dynv/Xml.cpp
@@ -23,6 +23,7 @@
#include "common/Scoped.h"
#include <expat.h>
#include <sstream>
+#include <type_traits>
using namespace std::string_literals;
namespace dynv {
namespace xml {
@@ -72,7 +73,7 @@
using namespace std::string_literals;
if (!writeListStart(stream, name, dynv::types::typeHandler<T>().name))
return false;
- for (const auto &i: values) {
+ for (std::conditional_t<std::is_arithmetic_v<T>, T, const T &> i: values) {
if (!writeStart(stream, "li"s))
return false;
if (!types::xml::write(stream, i)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building gpick 0.3 (with patches for #109, #215, #216, #220) with scons on macOS 12 fails for me with:
The text was updated successfully, but these errors were encountered: