Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting Tests Fail #727

Closed
selmanozleyen opened this issue Jul 3, 2024 · 1 comment
Closed

Plotting Tests Fail #727

selmanozleyen opened this issue Jul 3, 2024 · 1 comment
Assignees
Labels
bug (not-urgent) Something isn't working; is not urgent to fix ci Continuous integration improvements test Improve or add new tests

Comments

@selmanozleyen
Copy link
Collaborator

Hi as you can see in this example run: https://github.com/theislab/moscot/actions/runs/9782549371/job/27009128578

these tests fail:

  • tests/plotting/test_plotting.py::TestPlotting::test_plot_cell_transition_params
  • tests/plotting/test_plotting.py::TestPlotting::test_plot_cell_transition

from what I saw the both expected and output plots seemed equivalent but had different orders etc. This might be due to version mismatch between the code that created the expected plots and the code that created the output plot. So maybe there can be a more long term solution for this: https://stackoverflow.com/questions/27948126/how-can-i-write-unit-tests-against-code-that-uses-matplotlib

@selmanozleyen selmanozleyen added ci Continuous integration improvements test Improve or add new tests bug (not-urgent) Something isn't working; is not urgent to fix labels Jul 3, 2024
@selmanozleyen selmanozleyen self-assigned this Jul 16, 2024
@selmanozleyen
Copy link
Collaborator Author

closed with #737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (not-urgent) Something isn't working; is not urgent to fix ci Continuous integration improvements test Improve or add new tests
Projects
None yet
Development

No branches or pull requests

1 participant