You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering if it would make more sense to inherit GWProblem from FGWProblem since FGW kind of includes GW in itself. This is a problem since when GW inherites prepare it removes the linear arguments: (xy_callback etc.). And because of this we need to use CompoundProblem.prepare instead of super().prepare which is not ideal if you ask me.
But this problem also exists in current code. I can currently run
gwp[('0','1')].set_x(...)
because gwp[('0','1')] is a OTProblem, gwp itself doesn't have set_xy and others. If you are talking about other methods, I didn't notice any method that only FGWProblem itself implements except these
I was wondering if it would make more sense to inherit
GWProblem
fromFGWProblem
since FGW kind of includes GW in itself. This is a problem since when GW inherites prepare it removes the linear arguments: (xy_callback
etc.). And because of this we need to useCompoundProblem.prepare
instead ofsuper().prepare
which is not ideal if you ask me.moscot/src/moscot/problems/generic/_generic.py
Lines 581 to 592 in d54060a
The text was updated successfully, but these errors were encountered: